-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Testing signature change for response command encode. #39110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing signature change for response command encode. #39110
Conversation
PR #39110: Size comparison from 576b957 to 4abbfb8 Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
4abbfb8
to
385b3eb
Compare
PR #39110: Size comparison from 576b957 to 385b3eb Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
385b3eb
to
499418a
Compare
PR #39110: Size comparison from 24069af to 499418a Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
c972171
to
6e0058d
Compare
PR #39110: Size comparison from 05e766b to 6e0058d Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39110: Size comparison from 05e766b to b099bdd Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize it's just a draft, but looks good - I think this is effectively what I tried to do with one of my iterations of EncodeForWrite
but this is cleaner 👍
Thanks again for the help!
PR #39110: Size comparison from 05e766b to 463f8eb Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
947e3e2
to
5a722f5
Compare
PR #39110: Size comparison from a9afc79 to 5a722f5 Increases above 0.2%:
Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
5a722f5
to
091c025
Compare
PR #39110: Size comparison from a9afc79 to 091c025 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Closing in favor of clean PR with good description in #39228, since there is not much useful content here. |
Testing
Just testing.